Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDL.SDL_OpenURL instead of Process.Start to open FAQ and Logs #20301

Merged
merged 1 commit into from Oct 1, 2022
Merged

Use SDL.SDL_OpenURL instead of Process.Start to open FAQ and Logs #20301

merged 1 commit into from Oct 1, 2022

Conversation

abcdefg30
Copy link
Member

Process.Start doesn't seem to work as previously any more. Using Process.Start("explorer.exe", path); would have worked for the Logs, but SDL.SDL_OpenURL works in both cases.

@abcdefg30 abcdefg30 added this to the Next release milestone Sep 16, 2022
RoosterDragon
RoosterDragon approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on Windows for me.

@PunkPun PunkPun merged commit a758180 into OpenRA:bleed Oct 1, 2022
@PunkPun
Copy link
Member

PunkPun commented Oct 1, 2022

Changelog

@abcdefg30 abcdefg30 deleted the viewLogsFAQ branch October 1, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

@RoosterDragon RoosterDragon RoosterDragon approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abcdefg30 @PunkPun @Mailaender @RoosterDragon