Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed No Players No Bots No Spectators label overlapping #20327

Merged
merged 1 commit into from Sep 26, 2022

Conversation

Mailaender
Copy link
Member

@penev92 penev92 added this to the Next release milestone Sep 25, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the logic itself is bogus.

https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Widgets/Logic/ServerListLogic.cs#L389

Only shows the label when there are zero players in a lobby, meaning spectators and bots text is never used. This is also true on release.

in 0b67b5b#diff-3d5dfbd38868fde4ca45f20d13e0f7160d0b91552c8edb6d831b3f832bd11fa9L325
I see that spaces separating the words are gone. It's visible in Orb's report

2022-09-25_00_34_29-OpenRA_-_Tiberian_Dawn

mods/common/languages/en.ftl Outdated Show resolved Hide resolved
@Mailaender
Copy link
Member Author

Moved the logic back to C# and added spacings.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But we still need to decide how to fix Bots and Spectators translations being redundant. Remove them or change when the label is visible?

@Mailaender
Copy link
Member Author

This label seems to be redundant to the list of players. I'd like to keep this a bug fix pull request and let people who enjoy redesigning UI decide what to do with it.

Copy link
Contributor

@dragunoff dragunoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label is not very useful because it only shows up for empty servers. The information it's carrying is not entirely redundant though because you can't tell how many of the clients are bots and how many players. Approving the fix and maybe we come up with a better way to show this information - maybe in the clients list.

@Mailaender Mailaender changed the title Fixed No Players No Bost No Spectators label overlapping Fixed No Players No Bots No Spectators label overlapping Sep 26, 2022
@PunkPun PunkPun merged commit 0080e98 into OpenRA:bleed Sep 26, 2022
@PunkPun
Copy link
Member

PunkPun commented Sep 26, 2022

Changelog

@Mailaender Mailaender deleted the no-players-bots-spectators branch September 27, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants