New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed No Players No Bots No Spectators label overlapping #20327
Conversation
af4e1b6
to
4d9795f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the logic itself is bogus.
https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Widgets/Logic/ServerListLogic.cs#L389
Only shows the label when there are zero players in a lobby, meaning spectators and bots text is never used. This is also true on release.
in 0b67b5b#diff-3d5dfbd38868fde4ca45f20d13e0f7160d0b91552c8edb6d831b3f832bd11fa9L325
I see that spaces separating the words are gone. It's visible in Orb's report
4d9795f
to
9b53ddd
Compare
Moved the logic back to C# and added spacings. |
9b53ddd
to
8862a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But we still need to decide how to fix Bots and Spectators translations being redundant. Remove them or change when the label is visible?
This label seems to be redundant to the list of players. I'd like to keep this a bug fix pull request and let people who enjoy redesigning UI decide what to do with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label is not very useful because it only shows up for empty servers. The information it's carrying is not entirely redundant though because you can't tell how many of the clients are bots and how many players. Approving the fix and maybe we come up with a better way to show this information - maybe in the clients list.
Reported by @Orb370 in https://discord.com/channels/153649279762694144/388282819371204608/1023452554878791720. I misinterpreted 0b67b5b#diff-3d5dfbd38868fde4ca45f20d13e0f7160d0b91552c8edb6d831b3f832bd11fa9L325 which only shows
No Players
on empty servers.