Reduce casts of traits that are already known to be IDisabledTrait
s
#20361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exts.IsTraitEnabled(this T trait)
usestrait is IDisabledTrait disabledTrait
(and thusFirstEnabledTraitOrDefault
does as well). That is not necessary if we already know thatT
is anIDisabledTrait
.I introduced a new
FirstEnabledConditionalTraitOrDefault
that directly checkswhere T : IDisabledTrait
in the signature and replaced unnecessary usages ofExts.IsTraitEnabled
with direct calls toIsTraitDisabled
.