Weapon shouldn't check warheads in IsValidAgainst #20369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
previously approved these changes
Oct 14, 2022
PunkPun
changed the title
|
then we need some tester on CNC and D2K to see if there is yaml that hardcode warhead target for targetable |
|
Note: PR changed and add can target attacker itself option. It is due to there is a bug for repair vehicle repair itself when its projectile use LaserZap and target damage with speard = 0c20. I don't know if it is by design but we'd better give an option to allow that |
abcdefg30
reviewed
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warheads should not block weapon from firing, since we already has InvalidTarget&ValidTarget in weapon. In this case, considering warheads block fire will be very confusing to user.
With this, we can also get more pref when weapon check fire.
Closes #16023