Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted the Dune 2000 mission strings #20390

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

Mailaender
Copy link
Member

for translation.

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we need to incorporate some things from the other PRs to be consistent (translation parameters for the times and enemy objectives being unnamed). Also made some spelling suggestions while we're at it.

mods/d2k/maps/atreides-01a/atreides01a.lua Outdated Show resolved Hide resolved
mods/d2k/maps/atreides-01a/atreides01a.lua Outdated Show resolved Hide resolved
mods/d2k/maps/atreides-01b/atreides01b.lua Outdated Show resolved Hide resolved
mods/d2k/maps/atreides-01b/atreides01b.lua Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/d2k/languages/lua/en.ftl Show resolved Hide resolved
@penev92
Copy link
Member

penev92 commented Feb 15, 2023

I was skimming through the Lua changes and was thinking why not have a bunch of variables at the top of the script (or one table) that have all the translations and are used throughout the script instead of calling UserInterface.Translate() everywhere. Then I saw there is a Messages table at the top of at least one script. So I have to ask - is there a reason not all translations are done like that?

@PunkPun
Copy link
Member

PunkPun commented Feb 15, 2023

Having all translations at the top would perhaps make lint tests work on missions?

mods/d2k/maps/atreides-02a/atreides02a.lua Outdated Show resolved Hide resolved
mods/d2k/maps/atreides-02b/atreides02b.lua Outdated Show resolved Hide resolved
mods/d2k/maps/harkonnen-05/harkonnen05.lua Outdated Show resolved Hide resolved
mods/d2k/maps/harkonnen-09b/harkonnen09b.lua Outdated Show resolved Hide resolved
mods/d2k/maps/ordos-03a/ordos03a.lua Outdated Show resolved Hide resolved
@penev92
Copy link
Member

penev92 commented Feb 18, 2023

There was no response to the above questions 🙁 but I do think we should do it (in a follow-up PR is fine).

@Mailaender
Copy link
Member Author

This pull request has the scope as defined in the title. Please create a new ticket for linting Lua translatable strings. Linting this is far from easy and you don't want this cramped in here.

@abcdefg30 abcdefg30 merged commit 5032b2b into OpenRA:bleed Feb 19, 2023
@abcdefg30
Copy link
Member

Changelog

@Mailaender Mailaender deleted the fluent-lua-d2k branch February 20, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants