-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted the Dune 2000 mission strings #20390
Conversation
7021d95
to
80fa492
Compare
80fa492
to
6f2974c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we need to incorporate some things from the other PRs to be consistent (translation parameters for the times and enemy objectives being unnamed). Also made some spelling suggestions while we're at it.
6f2974c
to
d49a324
Compare
d49a324
to
f99e1c1
Compare
f99e1c1
to
e97d990
Compare
I was skimming through the Lua changes and was thinking why not have a bunch of variables at the top of the script (or one table) that have all the translations and are used throughout the script instead of calling |
Having all translations at the top would perhaps make lint tests work on missions? |
e97d990
to
d75afa6
Compare
There was no response to the above questions 🙁 but I do think we should do it (in a follow-up PR is fine). |
This pull request has the scope as defined in the title. Please create a new ticket for linting Lua translatable strings. Linting this is far from easy and you don't want this cramped in here. |
for translation.