Issue20373 aicraft hangs midair

[ThomasChr]

Fixes #20373

CancelActivity() leads to an Aircraft which stands midair if the IdleBehavior is set to ReturnToBase. Copters can do that, Aicrafts can't.

So I let the aircraft start it's idle activity, this will fix standing in midair.
To make sure that I don't start idle activity on the ground I test if the aircraft is moving (flying) and only start idle if it really is flying.
I wanted to prevent something like idle activity on the airfield.

[ThomasChr]

Rebased on bleed to keep it hot and fresh.

[AspectInteractive2]

To make sure that I don't start idle activity on the ground I test if the aircraft is moving (flying) and only start idle if it really is flying. I wanted to prevent something like idle activity on the airfield.

From what I understand planes cannot land on the ground, only on an airfield, and the code above the edit you made already checks for whether an airfield is available. Therefore it would not be possible for the aircraft to be on the ground unless an airfield was available, making the MovementSpeed check redundant. So I would remove the If altogether along with its else clause and only keep the line with FlyIdle.

Separately, for the number of ticks we shouldn't be putting a fixed number such as 25. The number in the above code makes sense, aircraft.Info.NumberOfTicksToVerifyAvailableAirport (currently set to 150), since this is the standard amount of ticks to wait before checking for another airport (see below code snippet).

OpenRA/OpenRA.Mods.Common/Traits/Air/Aircraft.cs

Lines 150 to 151 in bedfa62

	[Desc("The number of ticks that a airplane will wait to make a new search for an available airport.")]
	public readonly int NumberOfTicksToVerifyAvailableAirport = 150;

[ThomasChr]

@AspectInteractive2 Thanks for your insight. Now there are no magic numbers anymore :-)

[AspectInteractive2]

Seems to work and the code looks right, particularly as we shouldn't be using CancelActivity() if we can avoid it. Only concern now is if this breaks any existing functionality, though that will require a playtest I am guessing.

[PunkPun]

Changelog