-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular installer part1 #20440
Modular installer part1 #20440
Conversation
846d79f
to
98eb72e
Compare
98eb72e
to
237d906
Compare
OpenRA.Mods.Common/Widgets/Logic/Installation/InstallFromDiscLogic.cs
Outdated
Show resolved
Hide resolved
237d906
to
dc70568
Compare
OpenRA.Mods.Common/Widgets/Logic/Installation/InstallFromDiscLogic.cs
Outdated
Show resolved
Hide resolved
d769e7e
to
0f35afc
Compare
0f35afc
to
27a7994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small issues with the latest amendment. I haven't yet had the opportunity to test the installer ingame.
OpenRA.Mods.Common/Widgets/Logic/Installation/InstallFromDiscLogic.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.Common/Widgets/Logic/Installation/InstallFromDiscLogic.cs
Outdated
Show resolved
Hide resolved
…s it may be a temp file.
27a7994
to
11f8115
Compare
The On bleed:
On this PR:
|
Tested and otherwise works as expected on macOS and Linux, so 👍 once the fix above is applied. |
11f8115
to
e604161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design looks fine. I can't be sure of the installation specifics as this isn't my area of expertise, but as this has been tested successfully and reviewed by pchote I also approve.
Merging as approved by both @pchote and @AspectInteractive2 |
Part 1 #20440
Part 2 #20445
Part 3 #20439
What we have here: