HarvesterBotModule should not command harvesters that cannot be ordered

[dnqbob]

When removing units "that cannot be ordered", we remove units that are dead/in world (see line 97), but later when we search new units, we add them back (see line 105). We should avoid add them back.

[Mailaender]

Does world.ActorsHavingTrait<Harvester>() really give you dead harvesters that are not in the world?

[PunkPun]

The whole module feels extremely sketchy. The resource search activity it tries to control is also probably the most performance intensive in the engine

[dnqbob]

Does world.ActorsHavingTrait<Harvester>() really give you dead harvesters that are not in the world?

I find this in my sync-report

Orders Issued:
	 ClientId: 1 OrderString: "Harvest" 
	 Type: "Fields".  
	 Subject: "cabharv 1551 (not in world)". 
	 Target: "92672,68056,0".
	 TargetString: "".
	 IsImmediate: False.
	 Player(PlayerName): Shattered AI 2

The harvester is not in world but it is in carryall

[dnqbob]

The whole module feels extremely sketchy. The resource search activity it tries to control is also probably the most performance intensive in the engine

Extractly. I also link an old issue from CA here:
Inq8/CAmod#23

This module used to cause huge perf loss when minefield was near confliction point

[Mailaender]

Doesn't hurt.

[Mailaender]

This probably effects Dune 2000 as well.

[abcdefg30]

Changelog

And picked to prep since it's a simple improvement:
d55af8d

[PunkPun]

related #18198