Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional support to RenderShroud/JammerCircle #20497

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

Mailaender
Copy link
Member

Closes #17333

@Mailaender Mailaender changed the title Added conditional support to Make RenderShroud/JammerCircle Added conditional support to RenderShroud/JammerCircle Dec 2, 2022
@Mailaender Mailaender force-pushed the disable-mgg branch 2 times, most recently from 18e431b to 31e66ef Compare December 2, 2022 20:26
PunkPun
PunkPun previously approved these changes Dec 4, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, removed the testcase commit so we can merge.

@pchote pchote merged commit 46caa2d into OpenRA:bleed Dec 19, 2022
@Mailaender Mailaender deleted the disable-mgg branch December 19, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderCircle type traits arent conditional
3 participants