Define and measure duration for text notifications in milliseconds #20502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragunoff
commented
Dec 3, 2022
abcdefg30
reviewed
Dec 3, 2022
dragunoff
force-pushed
the
feature/notificatioins-wall-time
branch
from
91d28dd
to
1c423f6
Compare
|
Update: Added update rule. |
PunkPun
reviewed
Dec 4, 2022
OpenRA.Mods.Common/UpdateRules/Rules/TextNotificationsDisplayWidgetRemoveTime.cs
Outdated
Show resolved
Hide resolved
dragunoff
force-pushed
the
feature/notificatioins-wall-time
branch
from
1c423f6
to
39a87f3
Compare
|
Update: Moved update rule and added to the update path. |
PunkPun
reviewed
Dec 4, 2022
dragunoff
force-pushed
the
feature/notificatioins-wall-time
branch
from
39a87f3
to
160c552
Compare
|
Update: fixed #20502 (comment) |
dragunoff
force-pushed
the
feature/notificatioins-wall-time
branch
from
160c552
to
7df81f5
Compare
|
Update: changed field name to |
abcdefg30
reviewed
Dec 12, 2022
During a game notification duration should be the same regardless of game speed. Switch to using wall-clock time defined in milliseconds instead of game ticks. Also use the opportunity to rename the field to "Duration" because "RemoveTime" is not so clear.
dragunoff
force-pushed
the
feature/notificatioins-wall-time
branch
from
7df81f5
to
753c6f0
Compare
|
Update: switch to measuring the time against |
PunkPun
approved these changes
Dec 15, 2022
abcdefg30
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification duration should be the same regardless of game speed. Switch to using wall-clock time defined in milliseconds instead of game ticks. Also use the opportunity to rename the field to "Duration" because "RemoveTime" is not so clear.
Closes #20501