Add a CanDeploy check to Transform at FrameEndTask

[PunkPun]

Closes #13984

[anvilvapre]

won't it still show the undeploy animation? or is that no issue? it will just not deploy at the end?

[PunkPun]

Oh I just realised. MCV doesn't have a deploy animation so actually I'm unsure. The animation might play but the unit won't transform.

We can't do much about this, it's a choice. Do we want the transform always after the animation stops playing or only if it's viable?

I see 3 options

• Only transform when viable
• If there's an animation - don't check, if there's no animation - check
• Expose this to yaml and let the modder decide on what should happen upon the animation completing

Skipping the check would be as simple as passing a null into the DoTransforms() so on a technical level each option is a clean solution. Though customisation might be a bit messy considering so many traits use this activity. FWIW I'm fine with the current state of the PR

[PunkPun]

I made it so when after playing the make animation deploying is invalid, it plays it in reverse

The testcase is a bit misleading because this is the Construction Yard's make animation and not the MCV's, so it's reversed. But it's enough for testing

Screen.Recording.2022-12-09.at.14.48.36.mov

[abcdefg30]

Confirmed that this still works. ✅

Btw, you can define

	make: factmake
		Length: *
		Frames: 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0

to fix the animation for the testcase.

[Mailaender]

Can you remove the test case? 62321f1

[PunkPun]

dropped the testcase

[Mailaender]

Changelog