Skip to content

Add the ability for technician and rocket soldier to fire from a pillbox#20538

Merged
penev92 merged 1 commit into
OpenRA:bleedfrom
PunkPun:garrisonableWeapons
Nov 15, 2023
Merged

Add the ability for technician and rocket soldier to fire from a pillbox#20538
penev92 merged 1 commit into
OpenRA:bleedfrom
PunkPun:garrisonableWeapons

Conversation

@PunkPun
Copy link
Copy Markdown
Member

@PunkPun PunkPun commented Dec 11, 2022

@PunkPun PunkPun force-pushed the garrisonableWeapons branch from e9c9d23 to af92003 Compare December 11, 2022 13:44
@AspectInteractive2
Copy link
Copy Markdown
Contributor

AspectInteractive2 commented Dec 17, 2022

There seems to be two ranged circles when the rocket soldier enters the pillbox, yet only the inner ranged circle is valid for the rocket soldier (it cannot shoot as far as the outer range circle).

image

@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented Dec 17, 2022

the second one is for anti-air

@AspectInteractive2
Copy link
Copy Markdown
Contributor

AspectInteractive2 commented Dec 17, 2022

Can it be a different colour? I can easily see people being confused by why there are two circles, and which one is for ground vs. which one is for air.

@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented Dec 17, 2022

I can easily see people being confused by why there are two circles, and which one is for ground vs. which one is for air.

Which is fine. It's just another way to hint at people that rocket soldier has different ranges for ground and for air

@anvilvapre
Copy link
Copy Markdown
Contributor

anvilvapre commented May 15, 2023 •
edited
Loading

what visually might work is to have a larger spacing between the dashes of the outer circle. to emphasize they are two different types of ranges.

@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented May 16, 2023

I'm not sure how that would make it clearer than it currently is

@PunkPun PunkPun force-pushed the garrisonableWeapons branch from af92003 to ad017e7 Compare August 9, 2023 07:38
Mailaender
Mailaender reviewed Aug 10, 2023
View reviewed changes
Comment thread mods/ra/rules/infantry.yaml
tttppp
tttppp approved these changes Sep 5, 2023
View reviewed changes
Copy link
Copy Markdown

@tttppp tttppp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. In Discord you mentioned medics and mechanics acting from PBs was considered immersion breaking, but I'd be interested to see these have garrisoned 'attacks' too.

penev92
penev92 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs at least 1 approving review by someone with write access.

@penev92 penev92 merged commit 9534443 into OpenRA:bleed Nov 15, 2023
@PunkPun
Copy link
Copy Markdown
Member Author

PunkPun commented Nov 15, 2023

Changelog

@PunkPun PunkPun deleted the garrisonableWeapons branch November 15, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mailaender Mailaender Mailaender left review comments

@penev92 penev92 penev92 approved these changes

+3 more reviewers

@ssyrnyk ssyrnyk ssyrnyk left review comments

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@tttppp tttppp tttppp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Needs +2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@PunkPun @AspectInteractive2 @anvilvapre @Mailaender @RoosterDragon @tttppp @penev92 @ssyrnyk