Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mods to customise the default rendering scale. #20573

Merged
merged 1 commit into from Dec 31, 2022

Conversation

pchote
Copy link
Member

@pchote pchote commented Dec 21, 2022

This PR implements the last major feature needed to create HiDPI mods where the default zoom level is zoomed out relative to the native sprite size.

Fixes #19744.
Fixes #19512.

Testcase 1: add the following to mod.yaml and notice that the viewport is now larger

WorldViewportSizes:
	DefaultScale: 0.5

Testcase 2: OpenRA/TiberianDawnHD@7eed99a

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit

OpenRA.Mods.Common/Traits/World/TerrainRenderer.cs Outdated Show resolved Hide resolved
@Mailaender Mailaender merged commit 6d438a9 into OpenRA:bleed Dec 31, 2022
@Mailaender
Copy link
Member

Changelog

@pchote pchote deleted the viewport-scale branch August 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants