Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the wording and explain the meaning of some labels in settings #20607

Merged
merged 1 commit into from Jan 9, 2023

Conversation

dragunoff
Copy link
Contributor

The wording on some of the labels in settings panel is not so clear. This has come up in conversations and player feedback on Discord several times. This PR:

  • Changes the label "Mute Background Music" to "Mute Menu Music" and adds a tooltip to make it clear that this is about the music in the menu when no specific track is playing. Technically this can also mute the background music in a map if it has AllowMuteBackgroundMusic set to true and hence the previous label.
  • Changes the label "Player Stance Colors" to "Player Relationship Colors" and adds a tooltip explaining what the feature does. I always found this confusing as a player and had to guess what it does. Also the term stances is used for unit stances and not for player relationships (it was also changed in code - see Rename Stance to PlayerRelationship #18677 and Rename Stances to Relationships in the yaml api #18678).
  • Add tooltips explaining the new transient notification options. This came up repeatedly on Discord (people couldn't figure out what the labels mean and how the changes would manifest) and was the initial motivation for this PR.

@pchote pchote added this to the Next release milestone Jan 9, 2023
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As you know I would love to see tooltips for most other settings as well 😉

@penev92 penev92 merged commit 04648a6 into OpenRA:bleed Jan 9, 2023
@penev92
Copy link
Member

penev92 commented Jan 9, 2023

Changelog

@dragunoff dragunoff deleted the feature/settings-tooltips branch January 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants