Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to check if an actor can be captured via Lua #20618

Merged
merged 1 commit into from Jan 30, 2023
Merged

Add an option to check if an actor can be captured via Lua #20618

merged 1 commit into from Jan 30, 2023

Conversation

abcdefg30
Copy link
Member

Revives #20276.
Closes #20616.

@abcdefg30 abcdefg30 added this to the Next release milestone Jan 17, 2023
penev92
penev92 previously approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the controversy about logging a message on failure, it doesn't cost us anything (like Pun said, this is supposed to happen rarely) and it might actually help someone, so I think it's fine 👍

@PunkPun PunkPun merged commit 77b06ac into OpenRA:bleed Jan 30, 2023
@PunkPun
Copy link
Member

PunkPun commented Jan 30, 2023

Changelog

7ad6cfd

@abcdefg30 abcdefg30 deleted the luaCapture branch January 31, 2023 15:46
@Porenutak Porenutak mentioned this pull request Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender left review comments

@PunkPun PunkPun PunkPun approved these changes

@penev92 penev92 penev92 left review comments

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

LUA crash when engineer is trying to capture Actor with disabled Capturable triat
5 participants
@abcdefg30 @PunkPun @Mailaender @penev92 @azarus