New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IMove.MoveOntoTarget interface #20621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
force-pushed
the
and-move-turn
branch
2 times, most recently
from
January 20, 2023 19:33
7ff1eac
to
a310c87
Compare
PunkPun
force-pushed
the
and-move-turn
branch
2 times, most recently
from
January 24, 2023 11:58
beb1a0f
to
9988882
Compare
penev92
reviewed
Jan 24, 2023
PunkPun
force-pushed
the
and-move-turn
branch
from
January 24, 2023 13:13
9988882
to
b4076e2
Compare
Mailaender
previously approved these changes
Jan 27, 2023
PunkPun
force-pushed
the
and-move-turn
branch
from
February 18, 2023 17:02
b4076e2
to
560317f
Compare
PunkPun
force-pushed
the
and-move-turn
branch
2 times, most recently
from
March 24, 2023 12:15
4ebf0ee
to
4f8429a
Compare
abcdefg30
reviewed
Mar 25, 2023
abcdefg30
reviewed
Apr 12, 2023
abcdefg30
reviewed
Apr 12, 2023
abcdefg30
reviewed
Apr 12, 2023
No functional changes to `MoveWithinRange` nor `MoveAdjacentTo`. I've just moved around code to for allow better overwriting.
In `TraitsInterfaces` we expose offset as WPos instead of CPos. In an upcoming PR we'll translate the same change to yaml.
abcdefg30
previously approved these changes
Apr 12, 2023
dropped the testcase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19163
Split from #20168
Addresses some concerns from #20187
IMove.MoveOntoTarget
MoveOntoAndTurn
activity.MoveOnto Activity
In the first commit I haven't done any functional changes to
MoveWithinRange
norMoveAdjacentTo
. I've just moved the code around to allow better overwriting.The testcase is there just to show off that you can now dock to moving docks. It's still not properly supported as in docked units don't attach and there are probably some bugs. But it's a start.