Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TiberianSunRefinery #20628

Merged
merged 1 commit into from Feb 18, 2023
Merged

Remove TiberianSunRefinery #20628

merged 1 commit into from Feb 18, 2023

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Jan 20, 2023 •
edited

Closes #13992
Split from #20168

Supersedes #20184
Partly supersedes #20178

TiberianSunRefinery was created as a way for voxel bodies for dock. But It was done in an inefficient and docking refactor blocking way. So in this PR I replace that solution with IDockClientBody interface

I also move WithDockingOverlay cnc -> common

@PunkPun PunkPun added this to the Next + 1 milestone Jan 20, 2023
@PunkPun
Remove TiberianSunRefinery
17985a9 
Also add IDockClientBody interface,
move WithDockingOverlay cnc -> common,
remove HarvesterDockSequence implementing classes
@Mailaender Mailaender merged commit 049d028 into OpenRA:bleed Feb 18, 2023
@Mailaender
Copy link
Member

Changelog

@PunkPun PunkPun mentioned this pull request Feb 18, 2023
Closed
@PunkPun PunkPun deleted the abstract-voxel branch February 18, 2023 16:03
@PunkPun PunkPun mentioned this pull request Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20231010
Development

Successfully merging this pull request may close these issues.

TiberianSunRefinery not needed in the future?
3 participants
@PunkPun @Mailaender @abcdefg30