ProductionTabsWidget: customize scroll decorations #20635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves initialization of Initialize getters for left/right arrow image from constructor Initialize method making it possible to override fields Decorations, DecorationScrollLeft and DecorationScrollRight after widget creation.
michaeldgg2
force-pushed
the
ProductionTabsWidget-CustomizeScrollDecorations
branch
from
39b8496
to
9136fa6
Compare
dragunoff
suggested changes
Jan 25, 2023
michaeldgg2
force-pushed
the
ProductionTabsWidget-CustomizeScrollDecorations
branch
from
fa9cbb1
to
372d576
Compare
PunkPun
reviewed
Jan 26, 2023
OpenRA.Mods.Common/UpdateRules/Rules/20230126/ProductionTabsWidgetAddTabButtonCollection.cs
Outdated
Show resolved
Hide resolved
michaeldgg2
force-pushed
the
ProductionTabsWidget-CustomizeScrollDecorations
branch
from
372d576
to
cbea814
Compare
…t scroll button and tab buttons.
michaeldgg2
force-pushed
the
ProductionTabsWidget-CustomizeScrollDecorations
branch
from
cbea814
to
5b39e87
Compare
dragunoff
approved these changes
Jan 27, 2023
michaeldgg2
deleted the
ProductionTabsWidget-CustomizeScrollDecorations
branch
michaeldgg2
restored the
ProductionTabsWidget-CustomizeScrollDecorations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to customize left/right arrow buttons and panels for left/right buttons and tab buttons.
Other changes:
AddFactionSuffixLogicadds suffix to bothTabButtonandArrowButtonand also forDecorationsfields onProductionTabsWidgetAdding faction suffix to
Decorationsdoesn't break CNC mod aschrome.yamldefines bothscrollpanel-decorations-nodandscrollpanel-decorations-gdi.Fixes #20619.