Reduce impact of max order length checks #20637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
reviewed
Jan 25, 2023
|
So semi-related: making 2k-3k-4k infantry (takes only a few minutes), selecting all and issuing attack orders in rapid succession reliably causes a connection drop followed by an NRE in our translation code because it tries to translate P.S.: The NRE is caught and logged, so it's not the worst thing in the world, but the game does end because of the connection drop (on bleed). But with the changes here none of that happens. |
pchote
force-pushed
the
order-length-limit
branch
from
9137cc4
to
809b25e
Compare
|
Updated. |
PunkPun
approved these changes
Jan 25, 2023
|
Honestly I think it would be better to band-aid multiplayer than ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
twoone simple workaroundsto reduce the chances of #19849 occurring.The
first commit raises the limit by a factor of 4 for MP games, and the secondcommit removes the limit completely for skirmish.