Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Lua function to concat two tables and fix IdlingUnits definitions for multiple reinforcements #20646

Merged
merged 2 commits into from
May 20, 2023

Conversation

abcdefg30
Copy link
Member

Lua has no built in method to concat two tables, so this introduces an utility method. Then this fixes some reinforcements in D2k missions not being added to the IdlingUnits table.

@penev92
Copy link
Member

penev92 commented Jan 30, 2023

Note that the reinforcements fixes are bound to affect the difficulty of the missions!

@abcdefg30 abcdefg30 added this to the Next Release milestone Mar 13, 2023
@penev92
Copy link
Member

penev92 commented Mar 28, 2023

This needs a rebase now.

@abcdefg30
Copy link
Member Author

Rebased.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mailaender Mailaender merged commit b623214 into OpenRA:bleed May 20, 2023
@Mailaender
Copy link
Member

Changelog

@abcdefg30 abcdefg30 deleted the utilsConcat branch May 20, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants