Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Wanders and AttackWander queue activities instead of resolving orders #20655

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

abcdefg30
Copy link
Member

Seems like order resolving was done to allow both Aircraft and Mobile actors to use the trait(s), but since then the IMove interface allows us to create an activity for both.

OpenRA.Mods.Common/Traits/Wanders.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/AttackWander.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Wanders.cs Outdated Show resolved Hide resolved
@abcdefg30
Copy link
Member Author

Updated.

@PunkPun
Copy link
Member

PunkPun commented Feb 24, 2023

For some reason target lines aren't shown in creeps. I suppose that has to do with player relations and is out of scope of this PR

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mailaender Mailaender merged commit 040fbf9 into OpenRA:bleed Mar 11, 2023
@Mailaender
Copy link
Member

No changelog, as this does not change behavior nor game rules.

@PunkPun
Copy link
Member

PunkPun commented Mar 12, 2023

Changelog

@abcdefg30 abcdefg30 deleted the fixWanders branch March 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants