Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransformsIntoDockClient #20659

Merged
merged 2 commits into from Dec 2, 2023
Merged

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Feb 10, 2023

split from #20168

This mimics the other TransformsInto* traits. When rearming code is absorbed into the new docking codebase it will supersede the TransformsIntoRepairable trait.

I've made the Harvester not depend on the Mobile trait so that modders would be able to have transformable harvesters

@PunkPun PunkPun added this to the Next + 1 milestone Feb 10, 2023
@PunkPun PunkPun force-pushed the transforms-dock branch 4 times, most recently from 09f9343 to 36e259f Compare February 19, 2023 11:25
@PunkPun PunkPun modified the milestones: Next Release, Next + 1 Apr 9, 2023
@PunkPun PunkPun force-pushed the transforms-dock branch 2 times, most recently from 6b4ed05 to 46d3ecc Compare August 8, 2023 14:07
@PunkPun PunkPun changed the title Add TransformsIntoDockClientManager Add TransformsIntoDockClient Oct 21, 2023
@PunkPun
Copy link
Member Author

PunkPun commented Oct 21, 2023

rebased and renamed the new trait to TransformsIntoDockClient

@PunkPun PunkPun force-pushed the transforms-dock branch 2 times, most recently from 00fe274 to d39941a Compare October 31, 2023 20:01
@PunkPun PunkPun force-pushed the transforms-dock branch 2 times, most recently from 638c582 to 012ddff Compare November 27, 2023 16:40
@Mailaender Mailaender merged commit d67e0a4 into OpenRA:bleed Dec 2, 2023
3 checks passed
@PunkPun PunkPun deleted the transforms-dock branch December 2, 2023 12:51
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants