-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Nod Covert Operations mission: scb30ea - Eviction Notice #20660
Conversation
Hi. I haven't looked at the changes yet, but there are some lint errors reported by the utility:
|
Can i run this lint test myself on my pc? Just to check before trying to push on every change. |
Yes, you can run |
Well, test doesn't show any error for me now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First observations:
- There is a single civilian in the village which isn't hostile (no attack cursor) and has the "Unit Lost" notification playing when dying. Is that intentional?
- The objective to collect all money didn't complete for me
- Directly sending two mammoth tanks into the base on normal difficulty seems a bit harsh to me. (I assume that is
grnf3
? It would be nice if those were a bit more descriptive names. I can help with that later though.)
No, he was there in the original map, simply i didn't change that. Maybe he's there to throw the flare? Like a spy possibly.
There are 5 crates, did you found it? I managed to build and run the dev_version and it works for me.
It's grnf1 (i'll change few names like that for more descriptive ones). |
Hello, could you squash the commits? |
Sorry, can't understand what you mean by squash, my english is far from perfect. Can you explain? |
Sorry again, i cant figure out how to do it. I'll try again later. |
Sorry for the long delay in answering.
I like the idea. We should definitely either do something with the civ or change its owner. As it is now it just feels weird Imo, and gives you a "Unit Lost" notification.
My mistake, I didn't notice the crate spawned by the single house in the north.
That works quite good. I still think the mammoths are a bit strong, but now it's not random any more and should be predictable by the player. |
No problem at all. Maybe change the civilian for a minigunner? For the flare story. Or better remove it? |
Replaced the civilian with a minigunner, it's more clear now that a nod unit was there, waiting reinforcements. |
Done. |
I extracted (with xcc mixer) and converted scb30ea.ini/bin from sc-001.mix. According to https://cnc.fandom.com/wiki/Eviction_Notice_(Covert_Operations) and the new c&c remastered, its scb30ea Nod Covert Operations. Don't know where #4988 list came from, but it does not coincide with any list i can find. |
OK, thanks. Then we may need to fix #4988 |
Just fixed a bug i accidentally introduced while renaming this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! This is more of a playtest review than a code review. I went through on Hard and Normal, after completing the original mission for comparison. I thought this was a pretty good translation to ORA, so kudos.
I did find it a bit rough to complete, but this was even more true of the original in my experience, and most of the failures were early game. That's fair enough since it's an expansion mission for a game that's routinely mean. I'll also share that the Ion Cannon zapped one of my turrets and the civilian building next to it. That prompted a warning about wrecking the village, which I found amusing. This is not a critique; no change is needed!
I have not had issues with how the script works and I don't intend to suggest large changes. However, I do have suggestions for easy polish if you can indulge me.
#20743 will get a look from me once I can manage the original. The early game has been a doozy, and then I learned Nod has nukes on that map. Huzzah.
Nice review, thanks. I'll take a look on all of this. |
Updated with suggested changes by JovialFeline, renamed map files and capture structures function improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM sans a few spacing nits.
Spaces removed 😉 |
Hi again, i've been porting this Nod map while learning how to do it. I hope its ready and good enough, at least i had fun doing it.