Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the save dialogue #20664

Merged
merged 3 commits into from Mar 31, 2023
Merged

Polish the save dialogue #20664

merged 3 commits into from Mar 31, 2023

Conversation

abcdefg30
Copy link
Member

  • Makes the save game title field take focus when opening the save game browser
  • Allows to save a game by pressing enter after entering a title/name
  • Does no longer display the overwrite warning when not actually overwriting a save
    (Testcase: Select a save and change the filename text before saving)

@abcdefg30
Make the save game title field take focus
d9c2030
@abcdefg30
Allow saving games by pressing enter
8611f16
@abcdefg30
Don't always display the overwrite dialogue
08cccaf 
When a save was selected but the filename text was changed,
we don't overwrite the existing save, so we don't need a dialogue
PunkPun
PunkPun reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

perhaps also make escape hotkey quit the panel?

@PunkPun PunkPun merged commit 75a47aa into OpenRA:bleed Mar 31, 2023
@PunkPun
Copy link
Member

PunkPun commented Mar 31, 2023

Changelog

@abcdefg30 abcdefg30 deleted the saveDialog branch March 31, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: Needs +2 PR: Unaddressed comment(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abcdefg30 @PunkPun @RoosterDragon @Mailaender