Turn some code style rule severity from suggestion to warning #20680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
force-pushed
the
rules
branch
3 times, most recently
from
75114d1
to
6cba77e
Compare
RoosterDragon
previously approved these changes
Feb 20, 2023
abcdefg30
reviewed
Feb 22, 2023
Comment on lines
+254
to
+256
| #pragma warning disable IDE0047 | ||
| (*op++) = *ip++; | ||
| #pragma warning restore IDE0047 |
There was a problem hiding this comment.
Why do we need to disable this here? Are the parentheses not unnecessary but the warning still appears? Line 251 has the same? 🤔
There was a problem hiding this comment.
Try removing parenthesis. Something very weird is going on
There was a problem hiding this comment.
If you remove the parenthesis rule SA1023 kicks in:
Dereference symbol '*' should not be preceded by a space. csharp(SA1023)
Comment on lines
+72
to
+74
| #pragma warning disable IDE0047 | ||
| (*(c + s * 256 + h)) = Color.FromAhsv(h / 255f, 1 - s / 255f, V).ToArgb(); | ||
| #pragma warning restore IDE0047 |
There was a problem hiding this comment.
Same here. Also the outer for loop would need braces.
penev92
reviewed
Feb 24, 2023
| @@ -183,6 +183,9 @@ dotnet_diagnostic.CA1827.severity = warning | |||
| # Use Length/Count property instead of Enumerable.Count method. | |||
| dotnet_diagnostic.CA1829.severity = warning | |||
|
|
|||
| # Use span-based 'string.Concat' (incompatible with mono builds). | |||
There was a problem hiding this comment.
Maybe at least add a TODO here, reminding this should be enabled if/when we drop Mono?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use null propagation
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0031
Remove unnecessary parentheses
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048
Silencing
Use span-based 'string.Concat'suggestion as span it is incompatible with MONOhttps://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1845