Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce code rule IDE0039 #20697

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Enforce code rule IDE0039 #20697

merged 1 commit into from
Feb 27, 2023

Conversation

RoosterDragon
Copy link
Member

@RoosterDragon RoosterDragon commented Feb 24, 2023 •
edited
Loading

Enforces IDE0039 Use local function instead of lambda
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0039

Supersedes #20673

penev92
penev92 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abcdefg30 abcdefg30 merged commit d4135d6 into OpenRA:bleed Feb 27, 2023
@penev92
Copy link
Member

penev92 commented Feb 27, 2023

Changelog

@RoosterDragon RoosterDragon deleted the style-ide0039 branch February 28, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penev92 penev92 penev92 approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoosterDragon @penev92 @abcdefg30