When running a server, don't load minimap previews into memory. #20704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
reviewed
Feb 26, 2023
|
Would this be helpful for the utility too? |
|
some commands may require maps map previews, that would need more investigation |
|
LGTM |
RoosterDragon
force-pushed
the
server-mem
branch
from
e217006
to
7972e83
Compare
PunkPun
approved these changes
Feb 26, 2023
I can't locate any call sites from the utilities that would end up loading preview images, so it would seem not. |
ThomasChr
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory usage when starting up a server for the ra mod from 113 MB to 88 MB.