-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colors in gamma space being treated as if they were in linear space #20708
Conversation
On second thought, it would be better to pass the original color into |
Now passing color directly |
OK, from what I read this does make sense. That explanation was for me to make sure I understood correctly, for someone to confirm or deny if I did understand correctly and possibly to help others that like me did not have previous knowledge of the matter understand what's going on. |
PlayerColorRemap expected colors in linear space yet we provided them in gamma. We fix this by instead expecting gamma space colors and then converting them into linear space ourselves.
Renamed the commit / added a description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
And commit on prep. |
Fixes #20415 (comment)
PlayerColorRemap expected colors in linear space yet we provided them in gamma. We fix this by instead expecting gamma space colors and then converting them into linear space ourselves.
Fix proposed by @pchote