Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce code rule IDE0048 #20711

Merged
merged 1 commit into from Mar 1, 2023
Merged

Conversation

RoosterDragon
Copy link
Member

Enforces IDE0048 Add parentheses for clarity
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048

This works in tandem with the existing rule: IDE0047 Remove unnecessary parentheses. I have set the four available dotnet_style_parentheses options to settings that best match the prevailing style, but feel free to suggest changes if these seem off. See the docs above for details of the settings.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are cases where "redundant" parentheses can improve readability, but I know that is subjective, so OK

@penev92 penev92 merged commit 8ee6957 into OpenRA:bleed Mar 1, 2023
@penev92
Copy link
Member

penev92 commented Mar 1, 2023

Changelog

@RoosterDragon RoosterDragon deleted the style-ide0048 branch March 2, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants