Fix return fire logic ignoring AutoAttack priotities #20736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillermoqnk
changed the title
PunkPun
reviewed
Mar 10, 2023
|
I propose to name the commit to something like
|
Guillermoqnk
changed the title
Added brand new feature Unnecessary assignmet removed
Guillermoqnk
force-pushed
the
TargetClosestUnitWhenGreaterThanRFStance
branch
from
34960c7
to
3276731
Compare
RoosterDragon
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Thanks for fixing this one.
As this is your first contribution, you can choose to add yourself to the https://github.com/OpenRA/OpenRA/blob/bleed/AUTHORS file if you wish - just add another commit onto this PR if you do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20731
Change when stop order is given:
-When stance is return fire, units keeps retaliating.
-When you change to defense it's keeps retaliating till you give the order.
-Once the order is given it retargets to the closest unit.
If you go back to returnfire it retaliate again.