Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sequences linting to ingame lobby #20751

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add sequences linting to ingame lobby #20751

merged 1 commit into from
Apr 7, 2023

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Mar 17, 2023

To test make sure

OpenRA/OpenRA.Game/Server/MapStatusCache.cs

Line 81 in 384435f

status = enableRemoteLinting && map.Status != MapStatus.Available ? Session.MapStatus.Validating : Session.MapStatus.Playable;

that status is set to Session.MapStatus.Validating

@PunkPun PunkPun requested a review from pchote March 17, 2023 08:21
@PunkPun
Copy link
Member Author

PunkPun commented Mar 17, 2023

Most of the RA maps on resource centre will fail this lint test

pchote
pchote approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible but trusting that others have tested ingame.

@pchote pchote merged commit e4ba973 into OpenRA:bleed Apr 7, 2023
@pchote
Copy link
Member

pchote commented Apr 7, 2023

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/a8186cee96ff001f832d6b7ca15f01711ee32c73

@PunkPun PunkPun deleted the check-sequences branch April 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@Mailaender Mailaender Mailaender approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PunkPun @pchote @Mailaender