Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stance icon not updating when selecting units #20759

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix stance icon not updating when selecting units #20759

merged 1 commit into from
Mar 28, 2023

Conversation

ThomasChr
Copy link
Contributor

Will fix #20755

@ThomasChr ThomasChr marked this pull request as draft March 22, 2023 15:51
@ThomasChr ThomasChr mentioned this pull request Mar 22, 2023
Closed
@ThomasChr ThomasChr force-pushed the fix_stance_icon branch 2 times, most recently from 4f436db to a6958a4 Compare March 23, 2023 11:51
@ThomasChr ThomasChr marked this pull request as ready for review March 23, 2023 11:58
PunkPun
PunkPun previously approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RoosterDragon
RoosterDragon suggested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of the callers to SetStance manually set PredictedStance as well. You could remove those extra sets if SetStance will now deal with them.

RoosterDragon
RoosterDragon previously approved these changes Mar 27, 2023
View reviewed changes
@ThomasChr
Copy link
Contributor Author

@RoosterDragon
Good catch!
Both locations are removed and we're saving at least 2 cpu cycles now ;-)

@RoosterDragon
Copy link
Member

Candidate for prep?

@PunkPun PunkPun merged commit 9e08176 into OpenRA:bleed Mar 28, 2023
@PunkPun
Copy link
Member

PunkPun commented Mar 28, 2023

Candidate for prep?

Picking to prep isn't as simple. There are quite a few changes

@PunkPun
Copy link
Member

PunkPun commented Mar 28, 2023

Changelog

@PunkPun
Copy link
Member

PunkPun commented Mar 28, 2023

989dfb6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

units stance icon reverts after savestate
3 participants
@ThomasChr @RoosterDragon @PunkPun