Installer fixes and enhancements. #20776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
reviewed
Mar 30, 2023
OpenRA.Mods.Common/Installer/SourceActions/ExtractZipSourceAction.cs
Outdated
Show resolved
Hide resolved
IceReaper
force-pushed
the
installer-enhancements
branch
from
d230944
to
358cbe3
Compare
Mailaender
previously approved these changes
Mar 30, 2023
abcdefg30
reviewed
Mar 30, 2023
OpenRA.Mods.Common/Installer/SourceActions/ExtractZipSourceAction.cs
Outdated
Show resolved
Hide resolved
IceReaper
force-pushed
the
installer-enhancements
branch
from
358cbe3
to
83fc205
Compare
RoosterDragon
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoG and Steam installations may have DLCs. This results in optional files. We already have the IDFiles entry to verify a specific file exists, but currently both implementations will ignore the IDFiles entry completely. This PR fixes that. This not only fixes DLC files, but also ensures the installer no longer crashes when you delete the game folder, but keep the app manifest file (steam) or the registry (gog) intact.
We already have a bunch of extractors but we were missing the most basic one: zip files! I also added that. (Used for OpenE2140, as the GoG version ships the soundtrack as .zip)