Fixed MP3 detection. #20778
Merged
Fixed MP3 detection. #20778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
reviewed
Mar 31, 2023
abcdefg30
approved these changes
Apr 2, 2023
RoosterDragon
approved these changes
Apr 3, 2023
|
Thanks for cleaning up after me. |
|
For stable? |
|
I don't think it's necessary, but I wouldn't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding MP3 to the audio formats in mod yaml, everything listed afterwards will break, as the mp3 implementation does not check for the mp3 headers. This PR fixes this, so the mp3 loader wont be used for non-mp3 files, breaking following formats.