Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server launch scripts #20783

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Server launch scripts #20783

merged 3 commits into from
Apr 15, 2023

Conversation

ThomasChr
Copy link
Contributor

Came up in Discord. User wanted to override Server.Map when using launch-dedicated.sh - didn't work.
I'm not quite sure if I should squash those two commits, the other one is kind of unrelated.

PunkPun
PunkPun previously approved these changes Apr 3, 2023
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun
Copy link
Member

PunkPun commented Apr 4, 2023

Could you also rename JoinChatDelay to FloodLimitJoinCooldown?

@ThomasChr
Copy link
Contributor Author

Done. Shall I squash the three commits?

@penev92
Copy link
Member

penev92 commented Apr 14, 2023

Shall I squash the three commits?

IMO it's fine.
If you do squash them make sure to list all 3 changes in the commit message.

@ThomasChr
Copy link
Contributor Author

ThomasChr commented Apr 14, 2023

Okay, then I‘m not squashing 😊

@abcdefg30 abcdefg30 merged commit 57fba4e into OpenRA:bleed Apr 15, 2023
@abcdefg30
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants