Support dos paths in registry. #20785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceReaper
force-pushed
the
installer-enhancements
branch
from
ddde32f
to
2b820ac
Compare
pchote
reviewed
Apr 4, 2023
OpenRA.Mods.Common/Installer/SourceResolvers/RegistryDirectorySourceResolver.cs
Outdated
Show resolved
Hide resolved
IceReaper
force-pushed
the
installer-enhancements
branch
from
2b820ac
to
c4aa546
Compare
pchote
approved these changes
Apr 4, 2023
abcdefg30
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to say. Some games might actualy use an old installer which stores paths like this in the registry:
the path itself works flawless under windows, and the inserted line properly resolves those.