Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: using support power can uncloak actor #20786

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

dnqbob
Copy link
Contributor

@dnqbob dnqbob commented Apr 4, 2023

No description provided.

PunkPun
PunkPun previously approved these changes Apr 4, 2023
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abcdefg30
abcdefg30 previously approved these changes Apr 4, 2023
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm otherwise.

"'Dock' is triggered when docking to a refinery or resupplying.")]
[Desc("Events leading to the actor getting uncloaked. Possible values are: Attack, Move, Unload, Infiltrate, Demolish, Dock, Damage, Heal, SelfHeal and SupportPower.",
"'Dock' is triggered when docking to a refinery or resupplying.",
"'SupportPower' is triggered when using support power.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"'SupportPower' is triggered when using support power.")]
"'SupportPower' is triggered when using a support power.")]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@PunkPun PunkPun merged commit a261abb into OpenRA:bleed Apr 4, 2023
@PunkPun
Copy link
Member

PunkPun commented Apr 4, 2023

Changelog

@dnqbob dnqbob deleted the uncloak-sw branch April 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants