Add TS mobile EMP

[PunkPun]

Depends on #20824

#19211

https://cnc.fandom.com/wiki/Mobile_EMP

This PR is still WIP, I need to figure out some stats such as the range of the EMP or how to make the MEPM not float

[PunkPun]

I'm thinking this of this structure.

Add 2 new traits

• FireWeaponOnCondition
• GrantConditionOnChargedDeploy

Then we could use them for these 3 units

• MAD tank -> GrantConditionOnDeploy + FireWeaponOnCondition
• Saboteur Added manual Saboteur cloaking #17823 -> GrantConditionOnChargedDeploy
• Mobile EMP -> GrantConditionOnChargedDeploy + FireWeaponOnCondition

The difference between saboteur and memp is that for the latter the condition would activated for a long time, while for the former it would be for only one tick.

As for MAD tank, more logic will be need to be pushed out into other traits, it will likely need 2 FireWeaponOnDeploy traits for the 2 different interval weapons, it will need a trait for ejecting the driver and another for delayed self-destruction

[pchote]

Strongly disagree with the concept of a FireOnCondition trait. Conditions are states and shouldn't be used as events.

FireOnDeploy is the cleaner approach here (but maybe rename to FireWeaponOnDeploy to avoid confusion with it bursting into flame?)

[PunkPun]

Strongly disagree with the concept of a FireOnCondition trait. Conditions are states and shouldn't be used as events.

With MadTank as I described it would basically be a state. Repeatedly firing the weapon at a set interval until the condition is false.

[pchote]

That's describing something different, more like CashTrickler: the trait would be called e.g. FireWeapon with an Interval field, and just happen to be conditional.

[PunkPun]

Then I could just call it FireWeapon and just make it conditional

[Mailaender]

The unit is hovering despite being a tank with tracks:

but I don't know how to fix that.

[PunkPun]

As I comment in the description. I'm not sure what the best way to fix it is, I assume something is wrong in voxel importing?

Applying a 1/4 of a cell offset to the body does fix it. Pushed a fix.

[Mailaender]

Changelog