Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDI Covert Operations - Twist of Fate - scg41ea #20818

Merged
merged 1 commit into from
May 19, 2023

Conversation

YAmismo
Copy link
Contributor

@YAmismo YAmismo commented Apr 20, 2023

Same from #20743.
Sorry i messed up all. Still need to learn more git.

@YAmismo
Copy link
Contributor Author

YAmismo commented Apr 23, 2023

Fixed a few posible objective crashes.

@PunkPun
Copy link
Member

PunkPun commented Apr 25, 2023

Needs a rebase and difficulty translations added. See changelog #20585 for how.

@YAmismo
Copy link
Contributor Author

YAmismo commented Apr 26, 2023

Rebased and translations added.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add periodic reinforcements on easy difficulty? The Mission is quite lengthy

mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
@YAmismo
Copy link
Contributor Author

YAmismo commented May 4, 2023

Done.
Periodic reinforcements on easy difficulty? What could go wrong 😎.

@YAmismo
Copy link
Contributor Author

YAmismo commented May 6, 2023

Modified sams objective.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed all units aren't coloured. They are all of blue color, while structures & harvesters are red. Is this intentional?

The game crashed when I captured the radar.
Attempted to get trait from destroyed object (fact 77 (not in world))

Somehow the chinooks didn't land. They just stood there. I'd suggest just adding an additional reinforcement rather than making the existing one bigger
Screenshot 2023-05-07 at 16 21 31

@PunkPun
Copy link
Member

PunkPun commented May 7, 2023

Also got a crash if I captured the coms sentre after already having killed sams

Attempted to get trait from destroyed object (sam 101 (not in world))

@PunkPun PunkPun added this to the Next Release milestone May 7, 2023
@abcdefg30
Copy link
Member

I noticed all units aren't coloured. They are all of blue color, while structures & harvesters are red. Is this intentional?

This is probably just the default campaign coloring? (See the shared campaign-palettes.yaml file.)

@YAmismo
Copy link
Contributor Author

YAmismo commented May 8, 2023

Fixed both crashes from comm center capture and only 1 chinook should come now (was because of entering the cell trigger with multiple infantry at the same time).

About the colors... i'm with abcdefg30, just imported the map with the utility and added cnc|rules/campaign-palettes.yaml to map.yaml.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when I capture the coms centre before the objective appears, I don't get the objective to kill sams.

I still managed to get the crash somehowAttempted to get trait from destroyed object (sam 101 (not in world)

@YAmismo
Copy link
Contributor Author

YAmismo commented May 8, 2023

Now when I capture the coms centre before the objective appears, I don't get the objective to kill sams.

It's intended, before the first airstrike it is just a standard comm center, nothing special, i guess.

Fixed that crash too, my bad, stupid copy-paste xd.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now crashes when I kill the conyard.
Fatal Lua Error: [string "twist-of-fate.lua"]:83: attempt to index global 'NodAirSupport' (a nil value)

@YAmismo
Copy link
Contributor Author

YAmismo commented May 9, 2023

Fixed.

PunkPun
PunkPun previously approved these changes May 9, 2023
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mods/cnc/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/map.yaml Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
mods/cnc/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
@YAmismo
Copy link
Contributor Author

YAmismo commented May 11, 2023

Done.

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mission play well, good job! I find the secondary objective of destroying the SAM Sites a bit odd. I don't see a scenario where a player destroys the SAMs before having most of the main base destroyed already, making it a bit pointless. The briefing mentions that Getting that post back would be a major coup, so we could make the second objective about capturing the middle Construction Yard instead and always give the player an airstrike when they have a Comm Center. What do you think?

@YAmismo
Copy link
Contributor Author

YAmismo commented May 12, 2023

I find the secondary objective of destroying the SAM Sites a bit odd. I don't see a scenario where a player destroys the SAMs before having most of the main base destroyed already, making it a bit pointless. The briefing mentions that Getting that post back would be a major coup, so we could make the second objective about capturing the middle Construction Yard instead and always give the player an airstrike when they have a Comm Center. What do you think?

Yes, i thought about this while coding the map... not sure why i didn't do it.
You mean, remove sams objective but still have both secondary objectives, capture GDI old Con Yard and capture Comm Center too for air support?

@abcdefg30
Copy link
Member

You mean, remove sams objective but still have both secondary objectives, capture GDI old Con Yard and capture Comm Center too for air support?

Basically, but I would leave the Comm Center objective as is. Tying airstrikes to capturing the old Con Yard feels a bit weird. I'd either let the player have airstrikes like in skirmish or disable them entirely for this mission if they are too powerful.

@PunkPun
Copy link
Member

PunkPun commented May 12, 2023

When it comes to missions, I don't think you can make anything too powerfull

@YAmismo
Copy link
Contributor Author

YAmismo commented May 14, 2023

imagen

Could this be interesting? It was a GDI base we have to recover.
Or is it too much change to the original mission?

@abcdefg30
Copy link
Member

Looks good to me. 👍

@YAmismo
Copy link
Contributor Author

YAmismo commented May 16, 2023

Added recover recon post secondary objective.
Removed destroy sams secondary objective.

mods/cnc/languages/lua/en.ftl Outdated Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate-AI.lua Outdated Show resolved Hide resolved
mods/cnc/languages/lua/en.ftl Show resolved Hide resolved
mods/cnc/maps/twist-of-fate/twist-of-fate.lua Outdated Show resolved Hide resolved
@YAmismo
Copy link
Contributor Author

YAmismo commented May 18, 2023

Fixed.

@abcdefg30 abcdefg30 merged commit b1fd392 into OpenRA:bleed May 19, 2023
3 checks passed
@abcdefg30
Copy link
Member

Changelog

@YAmismo YAmismo deleted the scg41ea branch May 20, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants