Chrome string translation preparations #20820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs a rebase after #20804 was merged now. |
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
583cd5a
to
06e3be8
Compare
|
Rebased. |
PunkPun
reviewed
Apr 23, 2023
OpenRA.Mods.Common/Widgets/Logic/Ingame/ProductionTooltipLogic.cs
Outdated
Show resolved
Hide resolved
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
06e3be8
to
8b4e868
Compare
abcdefg30
reviewed
Apr 24, 2023
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
8b4e868
to
ec0841c
Compare
abcdefg30
requested changes
Apr 25, 2023
PunkPun
reviewed
Apr 26, 2023
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
ec0841c
to
1a1d6f8
Compare
|
Removed the offending commit so we can proceed faster on the rest. |
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
1a1d6f8
to
c06b703
Compare
abcdefg30
previously approved these changes
May 8, 2023
pchote
reviewed
May 8, 2023
Mailaender
force-pushed
the
l10n-chrome-labels
branch
from
c06b703
to
8b7006e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #20594 where it helps homogenize label IDs between TD and all the others. It also localizes dynamic strings that can't be automatically extracted.