Linting revamp #20830
Merged
Linting revamp #20830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Apr 29, 2023
abcdefg30
reviewed
Apr 29, 2023
abcdefg30
previously approved these changes
Apr 29, 2023
abcdefg30
previously approved these changes
Apr 29, 2023
pchote
reviewed
Apr 29, 2023
pchote
reviewed
Apr 29, 2023
PunkPun
force-pushed
the
lint
branch
3 times, most recently
from
475d456
to
1862f0d
Compare
pchote
reviewed
May 8, 2023
| @@ -33,7 +33,7 @@ void ILintRulesPass.Run(Action<string> emitError, Action<string> emitWarning, Mo | |||
| var traitName = traitInfo.GetType().Name; | |||
| traitName = traitName.Remove(traitName.Length - 4); | |||
| var locations = traitLocation.SystemActors.ToString().Replace(", ", " or "); | |||
| emitError($"{traitName} does not belong on {actorInfo.Key}. It is a system trait meant for {locations}."); | |||
| emitError($"`{traitName}` does not belong on `{actorInfo.Key}`. It is a system trait meant for {locations}."); | |||
There was a problem hiding this comment.
and we definitely don't add those to multiple word fields
Mailaender
reviewed
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does quite a lot. I split everything neatly into commits.
TLDR: