Improve CandidateMouseoverCells logic #20835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
reviewed
Apr 30, 2023
PunkPun
force-pushed
the
fix-cells
branch
2 times, most recently
from
b6806a0
to
3ece627
Compare
anvilvapre
reviewed
Jun 2, 2023
RoosterDragon
approved these changes
Jun 3, 2023
abcdefg30
reviewed
Jun 14, 2023
Mailaender
force-pushed
the
fix-cells
branch
from
9ffe713
to
9a3bfc8
Compare
|
Removed test case 9ffe713 |
Mailaender
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20813
I'm sure this isn't enough to fully fix CandidateMouseoverCells, but this does fix the height issues.
I added a cool visualisation of candidate cells as a testcase commit