New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crate spawned actors not crushing crushable actors and spawning inside other actors. #20849
Conversation
Side question. This seems like a fix for more and more things. Which makes sense. But if so much tasks become frame end tasks, being executed after a logic tick, won't you have the frame end tasks competing as well. |
I don't think so. End frame tasks are mostly there to handle object creation as to avoid modified collection during enumeration crashes. And as it seems much of the older code processes creations checks at the wrong time. It's not unlikely that some major refactor screwed a lot of code up. Fwiw I've also seen end frame tasks used for multithreading. |
Does that mean we can just put the |
I'm not sure what exactly you mean. But I don't really see a reason why we can't put SetPosition there. |
I was asking if we can just put the SetPosition stuff inside the task and leave the rest outside. |
No, then none of the bogus behavior would be fixed |
Can you remove the test case? |
removed |
I fix it by pushing cell selection logic into end world task, and by calling SetPosition after the actor was spawned