Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the notifyAttacks in AttackGarrisoned #20852

Merged
merged 1 commit into from
May 9, 2023
Merged

Cache the notifyAttacks in AttackGarrisoned #20852

merged 1 commit into from
May 9, 2023

Conversation

dnqbob
Copy link
Contributor

@dnqbob dnqbob commented May 9, 2023

Considering there can be a lot of passengers and fire at the same time, I don't see any reason we don't make it cached.

@PunkPun
Copy link
Member

PunkPun commented May 9, 2023

Looks like this was implemented in #5312

PunkPun
PunkPun approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@abcdefg30 abcdefg30 merged commit a65bb17 into OpenRA:bleed May 9, 2023
3 checks passed
@abcdefg30
Copy link
Member

Changelog

@dnqbob dnqbob deleted the ag-cache branch May 9, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@PunkPun PunkPun PunkPun approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnqbob @PunkPun @abcdefg30