New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make yaml node resolving optional #20860
Conversation
85e3887
to
4caf1d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IBeforeUpdate*
interfaces introduction feels like a no-op honestly. I don't mind it, I just feel it doesn't help anything.
The fix to the crash seems to be the reordering of the update rules, which as @abcdefg30 said is pretty ... magical.
That said, I think just reordering is fine and we should just be mindful of this with future update rules because anything else would likely be overkill and I have no better suggestion anyway.
Introduction of |
rebased |
Needs a rebase. |
rebased |
Partially fixes #20847
As we can't come up with a perfect solution the goal of this PR is just to make the situation much better.
IBeforeUpdate*
interfaces.As a side effect this should make the update rules run faster as we resolve way way less yaml