Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong definitions from TD's notifications.yaml #20866

Merged
merged 1 commit into from
May 19, 2023

Conversation

abcdefg30
Copy link
Member

Seems like #2801 and #8123 copied these from RA. I don't see the referenced sound files in the assets browser, so I don't think they exist in TD. Also seems like all those definitions aren't used (probably because they don't work).

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mailaender Mailaender merged commit dfe0c15 into OpenRA:bleed May 19, 2023
3 checks passed
@Mailaender
Copy link
Member

Changelog

@abcdefg30 abcdefg30 deleted the removeSounds branch May 19, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants