-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support enabling and disabling the low power notification via Lua #20869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FWIW this looks like a job for enabling and disabling traits via conditions, not for direct Lua manipulations (but I'm not going to block it anyway). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untested.
@@ -43,6 +43,13 @@ public void TriggerPowerOutage(int ticks) | |||
{ | |||
pm.TriggerPowerOutage(ticks); | |||
} | |||
|
|||
[Desc("Whether the player should receive a notification when low on power.")] | |||
public bool PlayLowPowerNotification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds a bit contradictionary.
PlaySound, or SendOrShowNotification.
And only play low power notifications in Twist of Fate when the player can build buildings. Otherwise the warning is more annoying than helpful.