ActorMap, avoid IPositionable trait lookup. #20891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPUbleed: ⌀ 2.56 ± 1.74 ms
No adverse side effects: probably well inside the error margin. |
Mailaender
previously approved these changes
May 27, 2023
PunkPun
reviewed
May 28, 2023
Mailaender
added
PR: Fixup requested
PR: Changes requested
and removed
PR: Needs +2
PR: Fixup requested
labels
|
There are more occurrences of this trait lookup. |
anvilvapre
force-pushed
the
20230529_actor_map_ipositionable
branch
from
ce07cdb
to
1f80196
Compare
abcdefg30
reviewed
Jun 1, 2023
anvilvapre
force-pushed
the
20230529_actor_map_ipositionable
branch
from
1f80196
to
5707c23
Compare
PunkPun
reviewed
Jun 1, 2023
anvilvapre
force-pushed
the
20230529_actor_map_ipositionable
branch
from
5707c23
to
0290111
Compare
CPUbleed: ⌀ 2.56 ± 1.74 ms
No adverse side effects, but also no improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial successor of #20351, which will be closed.
avoid trait dictionary lookup of IPositionable - by rather try to cast Actor.OccupiesSpace.
lookup up the trait in the trait dictionary requires a binary search on the actor in a list of all actors.