Fix bug that AI production pause when there are too many units in UnitDelays #20892

dnqbob · 2023-05-28T14:08:52Z

Problem To Solve

From line 119 to line 131 in UnitBuilderBotModule.cs, the AI check the validation of the unit after pick up a unit, and drop the unit when unit is invalid. This will cause a problem: when there is too many restrictions set in UnitDelays and UnitLimits, the production will pause because AI cannot find a proper unit to match the restrictions by randomly picking up an unit in a production queue.

For example, in TS I want Nod produce more "e1", because we need to prevent nearby human player winning easily by using early-game infantry rush, in order to do that we delay the trainning of other infantry (I think that is the most common usage of UnitDelays). However, due to the bug here, AI will only have 1/4 possibility to produce the correct unit and doing nothing at most of the dangrous early-game time, which is against our intial design on using UnitDelays.

The similar problem can happen when you using UnitLimits, even UnitToBuild when there is too many units in production queue is not assigned in UnitToBuild.

SideEffect

This PR will in no doubt wasting some perfs on checking the validation of the unit until find a correct unit to build. But it should be worthy.

OpenRA.Mods.Common/Traits/BotModules/UnitBuilderBotModule.cs

anvilvapre · 2023-06-03T16:30:29Z

OpenRA.Mods.Common/Traits/BotModules/UnitBuilderBotModule.cs

+			var desiredError = int.MaxValue;
+			foreach (var unit in buildableThings)
+			{
+				if (!Info.UnitsToBuild.ContainsKey(unit.Name) || (Info.UnitDelays != null && Info.UnitDelays.ContainsKey(unit.Name) && Info.UnitDelays[unit.Name] > world.WorldTick))


Do not first check to see if something is in the dictionary to after retrieve it. Use TryGetValue to do it in one pass.

Isn't the first always true? buildableThings is Info.UnitsToBuild so it will always contain the unit name?

So if a unit delay is set to have a value greater than world tick, then skip that unit. Why?

Isn't the first always true? buildableThings is Info.UnitsToBuild so it will always contain the unit name?

buildableThings is from queue.BuildableItems()

So if a unit delay is set to have a value greater than world tick, then skip that unit. Why?

This is the original design.

OpenRA.Mods.Common/Traits/BotModules/UnitBuilderBotModule.cs

anvilvapre · 2023-06-03T16:42:02Z

OpenRA.Mods.Common/Traits/BotModules/UnitBuilderBotModule.cs

+				if (error < 0)
+					return HasAdequateAirUnitReloadBuildings(unit) ? unit : null;
+
+				if (error < desiredError)


First you shuffle all units. Then to here make sure you first build the units farest off from the desired count?

Is there a need to shuffle then still? I think you loose your randomness here?

I think we should better combine both random and unit fraction control.

Consider this: we need medic forming 40% of the infantry squad, if AI build it fully randomly, then it is possible that we will get a suqad almost all medics, which is against our design.

You can consider the new ChooseRandomUnitToBuild is a combination of old ChooseRandomUnitToBuild and ChooseUnitToBuild with delay check and unit limit check.

The random is, when units in Info.UnitToBuild less than the allowed fraction, AI will build unit randomly. If unit in the list is all more than allowed fraction, AI will choose unit to build to keep fraction.

PunkPun · 2023-07-17T10:06:05Z

needs a rebase

dnqbob · 2023-07-17T11:37:46Z

Rebased. 发件人: ***@***.***> 发送时间: 2023年7月17日 18:06 收件人: ***@***.***> 抄送: ***@***.***>; ***@***.***> 主题: Re: [OpenRA/OpenRA] Fix bug that AI producion pause when there is too many unit in UnitDelays (PR #20892) needs a rebase ― Reply to this email directly, view it on GitHub<#20892 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADJAGQQOY6KN5ZTLV3MEDH3XQUFBRANCNFSM6AAAAAAYR33IVE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

PunkPun · 2023-07-29T10:26:38Z

An RA AI game crashed just almost as soon AI started to produce units.

desiredUnit needs a fallback, we can't just let it be null. I'd also assume that as it crashed very early into the game there's an error in the logic

dnqbob · 2023-07-29T10:35:45Z

shall I have a look at the log?

PunkPun · 2023-07-29T10:36:42Z

exception-2023-07-29T101518Z.log

dnqbob · 2023-07-29T10:49:34Z

An oversight, due to the base version of this PR have already drop the HasAdequateAirUnitReloadBuildings.

it crashed very early into the game there's an error in the logic

If this crash happends before AI build airfield or helipad, then there is an error in other place.

dnqbob · 2023-07-29T10:56:40Z

Also rebased to bleed.

PunkPun · 2023-07-29T11:13:13Z

With this PR AI's barracks idle way more than usual

dnqbob · 2023-07-29T12:33:26Z

I think it is due to I change IdleBaseUnitsMaximum as a hard limit, while we haven't adjust it in AI.yaml.

I have set it in ai.yaml.

PunkPun · 2023-07-29T14:05:12Z

It doesn't build even when it has no units

dnqbob · 2023-07-29T14:45:59Z

It doesn't build even when it has no units

In my test on map "Behind The Veil" it is not like that. 2 AI players (normal and rush) fills their squad immediatly, unless AI only build a kennel (because dogs has build limit).

Make sure you have this commit during tests, I have set the IdleBaseUnitsMaximum properly in this commit so production won't stall like before.

PunkPun · 2023-09-07T15:11:04Z

needs a rebase

dnqbob · 2023-09-07T16:04:19Z

Rebased, but untested.

mods/ra/rules/ai.yaml

…lays

PunkPun · 2023-09-08T15:08:34Z

OpenRA.Mods.Common/Traits/BotModules/UnitBuilderBotModule.cs

-		public readonly int IdleBaseUnitsMaximum = 12;
+		[Desc("If > 0, only produce units as long as there are less than this amount of units idling inside the base.",
+			"Beware: if it is less than squad size, e.g. the `SquadSize` from `SquadManagerBotModule`, the bot might get stuck as there aren't enough idle units to create squad.")]
+		public readonly int IdleBaseUnitsMaximum = -1;


We do want to have a specific value here. Imagine a scenario that an AI is stuck on an island. We don't want it to continue to produce units it can't use to attack

Though that usecase doesn't really even work. Units just get assigned to a squad and despite idling are no longer considered as idling

Well, I think developers would prefer limit is disabled by default or it will be confusing when squad is stuck on not producing units.

Though that usecase doesn't really even work. Units just get assigned to a squad and despite idling are no longer considered as idling

This can be solved with add a limit of the max number of each type squad in bot hand.

I kinda think that this variable should either be removed in its entirety, or the calculation of idle units changed to include idle squad units in base

Or the best idea is, change the design: SquadManager request units to build, UnitBuilder take the order to build.

If SquadManager find only hover units can reach the target, then it will build mostly hover unit on offensive. When SquadManager find it impossible to reach the target, it will just keep a protection squad and no order to UnitBuilder

PunkPun

While this PR does not resolve IdleBaseUnitsMaximum properly, it does not leave bleed more broken in any way. I think the benefits are strong enough to justify a merge

PunkPun · 2023-09-09T12:21:30Z

Changelog

dnqbob force-pushed the ai-pause branch 2 times, most recently from 7fc9f1f to 95e25bc Compare May 28, 2023 14:26

anvilvapre reviewed Jun 3, 2023

View reviewed changes

dnqbob force-pushed the ai-pause branch 2 times, most recently from 6a4a2e2 to d52a081 Compare June 4, 2023 01:34

PunkPun added the PR: Rebase me! label Jul 17, 2023

dnqbob force-pushed the ai-pause branch from d52a081 to 3378626 Compare July 17, 2023 11:37

PunkPun removed the PR: Rebase me! label Jul 17, 2023

dnqbob force-pushed the ai-pause branch from 3378626 to ca06353 Compare July 18, 2023 01:12

dnqbob force-pushed the ai-pause branch from ca06353 to 3298ed6 Compare July 29, 2023 10:45

dnqbob force-pushed the ai-pause branch from 3298ed6 to 430afc7 Compare July 29, 2023 10:56

dnqbob mentioned this pull request Aug 20, 2023

Add LoadCargoBotModule for AI cargo control OpenHV/OpenHV#767

Merged

PunkPun added the PR: Rebase me! label Sep 3, 2023

dnqbob force-pushed the ai-pause branch from 156d477 to 03c5e47 Compare September 7, 2023 00:09

dnqbob force-pushed the ai-pause branch from 03c5e47 to cb680f1 Compare September 7, 2023 16:03

PunkPun removed the PR: Rebase me! label Sep 7, 2023

PunkPun reviewed Sep 7, 2023

View reviewed changes

mods/ra/rules/ai.yaml Outdated Show resolved Hide resolved

Fix bug that AI producion pause when there is too many unit in UnitDe…

559c069

…lays

dnqbob force-pushed the ai-pause branch from cb680f1 to 559c069 Compare September 8, 2023 11:07

PunkPun reviewed Sep 8, 2023

View reviewed changes

PunkPun approved these changes Sep 9, 2023

View reviewed changes

PunkPun merged commit eab0bf8 into OpenRA:bleed Sep 9, 2023
3 checks passed

PunkPun mentioned this pull request Sep 9, 2023

UnitBuilderBotModule should stop producing units if the AI can't use them. #21048

Open

dnqbob deleted the ai-pause branch September 9, 2023 17:44

Mailaender changed the title ~~Fix bug that AI producion pause when there is too many unit in UnitDelays~~ Fix bug that AI production pause when there are too many units in UnitDelays Sep 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug that AI production pause when there are too many units in UnitDelays #20892

Fix bug that AI production pause when there are too many units in UnitDelays #20892

dnqbob commented May 28, 2023 •

edited

anvilvapre Jun 3, 2023

anvilvapre Jun 3, 2023

anvilvapre Jun 3, 2023

dnqbob Jun 4, 2023

anvilvapre Jun 3, 2023

dnqbob Jun 4, 2023 •

edited

dnqbob Jun 4, 2023

dnqbob Jun 4, 2023

PunkPun commented Jul 17, 2023

dnqbob commented Jul 17, 2023 via email

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023 •

edited

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023 •

edited

PunkPun commented Sep 7, 2023

dnqbob commented Sep 7, 2023

PunkPun Sep 8, 2023

PunkPun Sep 8, 2023

dnqbob Sep 8, 2023

PunkPun Sep 8, 2023

dnqbob Sep 8, 2023 •

edited

PunkPun left a comment

PunkPun commented Sep 9, 2023

Fix bug that AI production pause when there are too many units in UnitDelays #20892

Fix bug that AI production pause when there are too many units in UnitDelays #20892

Conversation

dnqbob commented May 28, 2023 • edited

Problem To Solve

SideEffect

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnqbob Jun 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PunkPun commented Jul 17, 2023

dnqbob commented Jul 17, 2023 via email

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023 • edited

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023

PunkPun commented Jul 29, 2023

dnqbob commented Jul 29, 2023 • edited

PunkPun commented Sep 7, 2023

dnqbob commented Sep 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnqbob Sep 8, 2023 • edited

Choose a reason for hiding this comment

PunkPun left a comment

Choose a reason for hiding this comment

PunkPun commented Sep 9, 2023

dnqbob commented May 28, 2023 •

edited

dnqbob Jun 4, 2023 •

edited

dnqbob commented Jul 29, 2023 •

edited

dnqbob commented Jul 29, 2023 •

edited

dnqbob Sep 8, 2023 •

edited