Added sanity checks to the Lua script trait

[Mailaender]

This catches some basic errors such as wrong trait location and case-sensitive file name pitfalls.

[anvilvapre]

CheckLuaScriptFileExistance?

Or would you add future other LuaScript validations also to this class.

No checks on strange or dangerous filenames? Like empty, spaces, dots and path characters, non utf8? Or not needed?

[PunkPun]

I think it would make sense to include this in the server lint pass as well

[Mailaender]

I thought about maybe migrating the Lua syntax check in here because we can check against the API, but not now.

[PunkPun]

For me this lint check is case insensitive. I suppose CI will trigger errors but my PC doesn't

[Mailaender]

macOS and Windows are case-insensitive.

[PunkPun]

by default yes, what I meant was shouldn't the lint always be case sensitive?

[Mailaender]

I guess it uses the native file system to load files and that is why.

[Mailaender]

Sorry, I won't reimplement operating system file systems for this. It is clearly nonsensical and out of scope.

[PunkPun]

Then it's not much of a sanity check. I thought the main purpose was to check case discrepancies

[PunkPun]

Anyhow, CI tests should catch it and that's enough to warrant a merge

[PunkPun]

Changelog